Wireshark-bugs: [Wireshark-bugs] [Bug 6373] Dissector for SPICE remote desktop protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 23 Sep 2011 01:56:55 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6373

Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7072|review_for_checkin?         |review_for_checkin-
               Flag|                            |

--- Comment #3 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-09-23 01:56:53 PDT ---
(From update of attachment 7072)
Hi,

a Quick and small review...

1) Attach a sample of SPICE Protocol (for test and regression...)
2) Use ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN for encoding attribut of
proto_tree_add_item (no TRUE / FALSE)
3) Remove DGBX function (use expert_info ?)
4) Attach your change in diff format (see
http://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html )

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.