Wireshark-bugs: [Wireshark-bugs] [Bug 6375] GPRS RLCMAC dissector not handling valid PDU
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 22 Sep 2011 12:19:19 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6375

Mike Morrin <wireshark@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wireshark@xxxxxxxxxxxxxxx

--- Comment #1 from Mike Morrin <wireshark@xxxxxxxxxxxxxxx> 2011-09-22 12:19:18 PDT ---
OK, I have looked a little more, and the bug is not quite as I described...

at around line 2200 of packet-gsm_rlcmac.c is a line:
  M_LEFT_VAR_BMP (EGPRS_PD_AckNack_t, EGPRS_AckNack.URBB,
EGPRS_AckNack.URBB_LENGTH, 0),

This is defining URBB, but it is the wrong type of array for this ie (the
bitmap does not extend to the end of the PDU).  Commenting out this line fixes
the dissector assertion, but still does not dissect the URBB.

It looks like handling of CSN_CALLBACK may need to be implemented to get this
to work correctly

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.