Wireshark-bugs: [Wireshark-bugs] [Bug 6329] proto: Use fill_label_xxx helpers in _proto_tree_add
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 11 Sep 2011 23:15:19 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6329

--- Comment #2 from Sylvain Munaut <246tnt@xxxxxxxxx> 2011-09-11 23:15:19 PDT ---
Hi,

> Hmm it does not look quite right to me  lbl_str[ITEM_LABEL_LENGTH];
> is newer filled with any thing and shoulden't it be a pointer to an
> allocated string? Am I missing something?

I don't quite get what you mean.

The parameter to fill_label_uint should be a preallocated string of length
ITEM_LABEL_LENGTH that will be completely overwritten. (the fill_label_xxx do a
g_snprintf(label_str, ITEM_LABEL_LENGTH, "xxx", ...) on it)

Cheers,

    Sylvain

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.