Wireshark-bugs: [Wireshark-bugs] [Bug 6126] 1588-2008 does not decode tlvType in Signaling Messa
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6126
--- Comment #13 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-07-31 20:32:42 PDT ---
(In reply to comment #10)
> Thanks for the comments.
> To Chris: I would take the time to select those excerpts, but only if this is
> accepted by the webmaster. I do not want either to violate Wireshark rules or
> waste my/your time.
I took a look at the capture file, read your initial comments more closely and
also looked at the packet-ptp.c dissector more closely. The biggest thing that
stands out to me is the comment from the packet-ptp.c file:
/* ToDO: Add dissector for TLVs and allow multiple TLVs */
The authors, presumably folks with access to the standard like you, simply
didn't implement the entire protocol dissector. And while I think posting a
small excerpt from the standard would constitute fair use (see
http://www.copyright.gov/fls/fl102.html), in this case, I don't think a small
excerpt would suffice. In order to fulfill the requirements of the "ToDO"
mentioned above, I believe too much of the standard would be needed such that
"fair use" could no longer be justified.
If you or someone from your organization is unable to submit a patch yourself,
then perhaps one of the packet-ptp.c authors could. You could try contacting
them to see if one or more of them would be willing to submit a suitable patch
to rectify the current dissector's shortcomings.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
