Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6163] Dissector for XR IDMS from ETSI TS 182 063 v3.5.2 Annex W

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6163

--- Comment #10 from Bill Meier <wmeier@xxxxxxxxxxx> 2011-07-31 20:37:17 EDT ---
> 
> The contents of buff are used in the next line:
> 
> item = proto_tree_add_string_format( content_tree, hf_rtcp_ntp, tvb, offset-8,
> 8, buff, "NTP timestamp of reception: %s", buff );
> 
> This line is used to display the decoded timestamp of reception. Anders
> mentioned in comment 2, that there is another solution for decoding and adding
> the timestamp, but I haven't thought about it so far.
> 
> regards
>           Torsten

What actually ended up getting committed is the following:
(assuming that I'm looking at the right place).

    buff=tvb_ntp_fmt_ts(tvb, offset-8);
    item = proto_tree_add_item(content_tree, hf_rtcp_ntp, tvb, offset-8, 8, 
        ENC_TIME_NTP|ENC_BIG_ENDIAN);
    PROTO_ITEM_SET_GENERATED(item);


See line 2207 and following of
http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/packet-rtcp.c?revision=38225&view=markup

Maybe using proto_tree_add_item with ENC_TIME_NTP is all that is needed to
display the field properly and Anders intended to remove the 'buff=...' line
...

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.