Wireshark-bugs: [Wireshark-bugs] [Bug 6138] Buildbot crash output: [in packet-opensafety] randpk
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 26 Jul 2011 07:54:52 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6138

--- Comment #8 from Roland Knall <rknall@xxxxxxxxx> 2011-07-26 07:54:52 PDT ---
(In reply to comment #7)
> Created an attachment (id=6724)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6724) [details]
> A possible patch to avoid crash.
> 
> I tested this patch and it avoids the crash.  Knowing nothing about the
> opensafety dissector though, is it acceptable to the opensafety developer?

It does not solve the underlying situation. The real issue here is, that the
openSAFETY packet is not really an openSAFETY packet. Therefore, it should
never be dissected at all. I'll submit a new patch, which will fix the
underlying situation. The new patch will prevent the dissection from going
through in this dissector, and return FALSE to wireshark, therefore allowing
dissection to continue with another dissector if needed.

The issue arises, because the openSAFETY heuristic dissection falsely thinks
this being a correct packet.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.