Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5956] kNet (KristalliNet) dissector for Wireshark

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5956

Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexis.lagoutte@xxxxxxxxx

--- Comment #10 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-07-23 07:17:21 PDT ---
Hi,

It is not possible to make a unique dissector for UDP/TCP/SCTP ? the payload is
the same for the 3 Transports Layer ?

Also from packet-knet-tcp.c (and packet-knet-stcp.c)

        proto_tree_add_bytes_format(tree, hf_knet_msg_messageid, buffer,
*offset, 1, NULL, "Message ID: PingRequest (%d)",messageid );

Why not use FT_UINT8 with value_string table ? 

        g_string_append_printf(info_field, "PingRequest ");
Why not use directly col_append_str ?

        proto_tree_add_bytes_format(payload_tree, hf_knet_msg_payload, buffer,
offset, 1, NULL, "PingID: %d", value);

Why not use a hf (hf_knet_msg_payload_pingid...) by type of payload ?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.