Wireshark-bugs: [Wireshark-bugs] [Bug 6134] Request for usefully defined #VERSION macro
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 20 Jul 2011 11:41:42 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6134

--- Comment #5 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-07-20 11:41:41 PDT ---
(In reply to comment #4)
> There is already code in the toplevel CMakeLists.txt. Can you please use the
> same variable names?

Or should the CMakeLists.txt be changed to use the same names as in
config.nmake since it was there first?  :)

What is the correlation, by the way?  Something like ....

config.nmake    CMakeLists.txt
VERSION_MAJOR   PROJECT_MAJOR_VERSION
VERSION_MINOR   PROJECT_MINOR_VERSION
VERSION_MICRO   PROJECT_PATCH_VERSION(?)
VERSION_BUILD   PROJECT_PATCH_VERSION(?)
VERSION_EXTRA   PROJECT_VERSION_EXTENSION(?)

Personally, I like the config.nmake names better; they're shorter and
consistently named.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.