Wireshark-bugs: [Wireshark-bugs] [Bug 5769] BACnet who-is request device range values are not de
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 18 Jul 2011 19:34:24 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5769

--- Comment #2 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-07-18 19:34:22 PDT ---
(In reply to comment #1)
> Created an attachment (id=6672)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6672) [details]
> Bugfix for 5769
> 
> A capture would have been more helpful than a screenshot to test the fix, but
> it was pretty simple fix.

So I don't know anything about BACnet and I'm not about to go purchase the
standard (http://www.bacnet.org/Ordering/index.html), but I assume that since
this field should be big endian, so too should all of the multi-byte fields?

After applying Michael's patch, a quick grep still shows at least 16 other
fields being added to the protocol tree in little endian format.  I assume all
these should be changed as well?  Affected fields:

hf_bacapp_invoke_id (2 occurrences)
hf_bacapp_type (7 occurrences)
hf_bacapp_pduflags
hf_bacapp_SEG
hf_bacapp_MOR
hf_bacapp_SA
hf_bacapp_NAK
hf_bacapp_SRV (2 occurrences)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.