Wireshark-bugs: [Wireshark-bugs] [Bug 5990] New: SERCOS III built-in dissector (from plugin)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 3 Jun 2011 07:58:18 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5990

           Summary: SERCOS III built-in dissector (from plugin)
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: mmann78@xxxxxxxxxxxx


Michael Mann <mmann78@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6449|                            |review_for_checkin?
               Flag|                            |

Created an attachment (id=6449)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6449)
Convert SERCOS III plugin to built-in dissector

Build Information:
Version 1.7.0(SVN Rev Unknown from unknown)

Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GTK+ 2.22.1, with GLib 2.26.1, with WinPcap (version
unknown), with libz 1.2.5, without POSIX capabilities, without libpcre, with
SMI
0.4.8, with c-ares 1.7.1, with Lua 5.1, without Python, with GnuTLS 2.10.3,
with
Gcrypt 1.4.6, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built
Jun
 3 2011), with AirPcap.

Running on Windows XP Service Pack 3, build 2600, with WinPcap version 4.1.2
(packet.dll version 4.1.0.2001), based on libpcap version 1.0 branch 1_0_rel0b
(20091008), GnuTLS 2.10.3, Gcrypt 1.4.6, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729
--
Converted SERCOS III from a plugin to a built in.  There are 2 patches:
1. Patch that modified the necessary makefiles
2. Patch that contains SERCOS III plugin source moved to the epan/dissectors
directory.  I did not modify this source at all from the plugin directory, but
I wasn't sure how a patch like this would work.  I was hoping that there was a
way within the source control to move files to different folders to preserve
history.

If source control cannot preserve the file history, I would recommend combining
all of the source into 1 file.  Each SERCOS III subdissector is fairly small
and could be managed in a single file.  I think this should be done anyway, but
I understand the argument of keeping source history.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.