Wireshark-bugs: [Wireshark-bugs] [Bug 5980] Add draft-ietf-6man-rpl-routing-header-03 Support (R
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 3 Jun 2011 05:19:32 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5980

--- Comment #5 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-06-03 05:19:32 PDT ---
(In reply to comment #4)
> Hi Alexis,
> 
> I normally try to use the same general mannerisms as the code around my patch,
> which in this case did use structures to get offsets. I'll re-write the patch
> to remove the structures.
> 
Yes i see but i planned to cleanup the IPv6 dissector...

> The proto_tree_add_ipv6/uint were required when the value doesn't come from the
> TVB structure. In this case the 'total segments' and 'ipv6 routing addresses'
> are both calculated values, and not directly read from the TVB.

Ok, should be put the item to "Generated"

>From README.developer  
PROTO_ITEM_SET_GENERATED()
--------------------------
PROTO_ITEM_SET_GENERATED is used to mark fields as not being read from the
captured data directly, but inferred from one or more values.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.