Wireshark-bugs: [Wireshark-bugs] [Bug 5905] A new dissector for Vuze DHT
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 25 May 2011 21:21:17 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5905

--- Comment #3 from Xiao Xiangquan <xiaoxiangquan@xxxxxxxxx> 2011-05-25 21:21:16 PDT ---
(In reply to comment #2)
> A few comments:
> 1) Please don't access the fields of a TVB directly (tvb->real_data in this
> case).  With SET_ADDRESS(), just use tvb_get_ptr().
> 2) fuzz testing gave me a core dump on the first run.  Adding a default case in
> dissect_vuze_dht_address():
> 
>   default:
>     addr.type = AT_NONE; <<< add this
>     break;
> 
> fixed it.
> 
> 3) tools/checkAPIs.pl reported non-ASCII characters in the file.
> 4) tools/checkhf.pl reported some unused hf_ variables.  Should they be used or
> removed?
> 
> Anyway, I'm out of time for tonight.


All fixed, thank you very much.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.