Wireshark-bugs: [Wireshark-bugs] [Bug 5753] New dissector for the openSAFETY protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 19 May 2011 00:59:00 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5753

Roland Knall <rknall@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6075|review_for_checkin?         |
               Flag|                            |
   Attachment #6075|0                           |1
        is obsolete|                            |

--- Comment #13 from Roland Knall <rknall@xxxxxxxxx> 2011-05-19 00:58:54 PDT ---
Created an attachment (id=6364)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6364)
Update patch version after fuzzy testing the dissector

(In reply to comment #12)
> (In reply to comment #6)
> > If you don't use variable or function outside .c file, it's good idea to make
> > them static.
> 
> This comment is still valid :)

I apologize. I thought I had fixed that with the last patch. However, all
normal variables and functions have been changed to static now. The only
functions not static are the ones for registering the dissector

Additionally I removed two functions, which are no longer needed, and the
prototype conversation functionality, as it will not be supported right now.

regards, 
Roland

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.