Wireshark-bugs: [Wireshark-bugs] [Bug 5784] New dissector for GSM A-bis OML
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 14 May 2011 07:00:49 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5784

Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeff.morriss.ws@xxxxxxxxx

--- Comment #1 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-05-14 07:00:46 PDT ---
A few comments based on a cursory review:

1) we'll need a sample capture for testing & (especially) fuzz testing

2) has this been fuzz tested?  There a are a couple unterminated value_strings
which will lead to cores.

3) I'd suggest running checkApis and checkhf on this.  For example, I noticed a
couple of hf_ entries with blurbs which matched the description.

4) It looks like the contents of the header file can/should be moved into the
.c file.

5) Looks like there may be a couple unneeded #includes (stdio, for example).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.