Wireshark-bugs: [Wireshark-bugs] [Bug 5893] VTP dissector enhancement to recognize VTP Join/Prun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 8 May 2011 07:33:04 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5893

--- Comment #11 from Peter Paluch <peter.paluch@xxxxxxxxxxxx> 2011-05-08 07:33:03 PDT ---
(In reply to comment #10)
> (From update of attachment 6299 [details])

Jaap,

Thank you very much for your comments. I apologize - these are my beginnings
with the Wireshark codebase, and I appreciate the guidance very much.

I will attach a reworked patch soon. I have moved the setting of the INFO
column to a separate function called before the if(tree) construct. I believe
that is the most direct way to implement it - the other way would be to split
the big if(tree) block in the dissect_vtp() function into several if(tree)
subblocks which I did not find particularly appealing nor readable.

Best regards,
Peter

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.