Wireshark-bugs: [Wireshark-bugs] [Bug 5893] VTP dissector enhancement to recognize VTP Join/Prun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 6 May 2011 03:22:42 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5893

Peter Paluch <peter.paluch@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #4 from Peter Paluch <peter.paluch@xxxxxxxxxxxx> 2011-05-06 03:22:37 PDT ---
Hello Jeff,

Thank you for reviewing the patch.

I personally suggest we remain with displaying separate First and Last VLAN IDs
(VIDs) as originally suggested in my patch, including separate hf_ variables
for Start VLAN ID, First VLAN ID and Active VLAN ID.

With your modifications to the patch, using the same hf_ variable for First
VID, Last VID and advertised active VIDs results in the inability to
distinguish between these three, both in the sense of filtering and in the
description of the displayed fields in the GUI. Seeing the First and Last VID
indicated simply as "VLAN" in the packet details is confusing/unintelligible,
and their description as being "Active (i.e. not pruned) VLAN ID" is
fundamentally wrong: they are neither active nor inactive, rather, they
constitute a range of VLANs to which the remaining bitmask array applies to.

Also, using a shared hf_ variable results in Start/End VIDs being both
considered as active when performing a filter. However, a Start/End VLAN may
still be advertised as pruned and should not therefore be mixed together with
the same hf_ variable that allows to filter for active VLANs.

On the other hand, I like very much your idea of using the proto_tree_add_uint
that will allow to actually filter the VTP Join messages according to the
active VLANs.

I am attaching a new diff file against the 1.4.6 stock version of packet-vtp.c,
implementing your idea of proto_tree_add_uint but keeping three hf_ variables.
I believe that three additional hf_ guint-s are acceptable.

Best regards,
Peter

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.