Wireshark-bugs: [Wireshark-bugs] [Bug 5828] ip.access nanoBTS vendor-specific RSL message types
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 3 May 2011 14:14:46 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5828

--- Comment #3 from pablo@xxxxxxxxxxxx 2011-05-03 14:14:45 PDT ---
(In reply to comment #2)
> Created an attachment (id=6280)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6280) [details]
> new revision of nanoBTS-specific RSL support

I'm sorry, I messed up a bit with bugzilla. I wrote a description for this new
patch.

First off, thanks Jeff for taking the time to review this contribution.

This new patch contains two changes that you suggested:

* a new TLV_TYPE_NONE type for unknown messages, if we would hit one, we skip
the parsing. This is more robust that the previous default to TLV_TYPE_FIXED.

* use guint8 instead of u_int8_t.

I decided not to use value_string-arrays as you suggested and keep using the
key-array approach, I hope that this is not a major inconvenient.

Thanks!

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.