Wireshark-bugs: [Wireshark-bugs] [Bug 5854] New Dissector: Locator/ID Separation Protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 25 Apr 2011 09:29:37 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5854

--- Comment #6 from Loránd Jakab <ljakab@xxxxxxxxxx> 2011-04-25 09:29:36 PDT ---
(In reply to comment #5)
> BTW, one comment I meant to make was: shouldn't the fields dissected by
> dissect_lisp_locator() be added with proto_tree_add_item() so they'd be
> filterable?

That's one of the improvements I was talking about. The current format was
chosen for ease of visual parsing, and it resembles the output of the command
line tool 'lig'. For each locator entry I will create a subtree with filterable
entries, that highlight the correct bytes in the payload.

> 
> Also, I did remove a couple of unused hf variables/entries and an unneeded
> include (glib.h).  (Would have written this last night, but the kids were
> driving me nuts...)

Some of the hf variables were supposed to be used in the future, and I forgot
the remove them from the submission. I submitted this somewhat unfinished patch
so that it could reach a wider audience sooner, and especially so that people
using Windows could get binaries when 1.5.2 is released :P

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.