Wireshark-bugs: [Wireshark-bugs] [Bug 5802] New: Rewrite&cleanup wiretap/file_wrappers
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 3 Apr 2011 02:51:12 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5802

           Summary: Rewrite&cleanup wiretap/file_wrappers
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: darkjames@xxxxxxxxxxxxxxxx


Created an attachment (id=6116)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6116)
Remove bsize argument from file_read() macro.

Build Information:
wireshark 1.5.1
--
file_read(buf, bsize, count, file) macro is compilant with fread function and
takes elements count+ size of each element, however to make it compilant with
gzread() it always returns number of bytes.

In wiretap file_read() this is not really used, file_read is called either with
 bsize set to 1 or count to 1.

Attached patch remove bsize argument from macro.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.