Wireshark-bugs: [Wireshark-bugs] [Bug 5759] Mysql protocol dissector: all fields should be littl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 18 Mar 2011 08:20:47 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5759

--- Comment #6 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-03-18 08:20:46 PDT ---
(In reply to comment #5)
> For Header Field FT_STRING(Z) and FT_(U)INT8, the encoding bit is not little or
> big endian, use ENC_NA

I guess hf_mysql_exec_flags should also use ENC_NA.  But before I commit this
change, I ran checkhf.pl on the mysql dissector, and it produced these 3 unused
header fields:

$ tools/checkhf.pl epan/dissectors/packet-mysql.c
Unused entry: epan/dissectors/packet-mysql.c, hf_mysql_response_code
Unused entry: epan/dissectors/packet-mysql.c, hf_mysql_row_length
Unused entry: epan/dissectors/packet-mysql.c, hf_mysql_parameter

I plan to remove them unless someone intends to add some code that uses them.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.