Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5694] Addition of BACnet Statistics Trees

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5694

Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeff.morriss.ws@xxxxxxxxx

--- Comment #2 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-02-23 10:44:33 PST ---
A few comments:

1) Does this comment:

-    if (tree) {
+    /* The if clause needs to be commented out for
+     BACnet Statistics. However, if filtering the display,
+     the statistics trees are not created correctly, they are
+     only built to a depth of 3 or so. The relevant part for that
+     behavior is here, I believe. */
+//    if (tree) {

mean that things don't work when using a display filter?  That should be fixed.

2) (possibly related to (1)): Why only do this when !tree?

+    /* update BACnet Statistics */
+    if (!tree)


Should it only be done on the first pass through the file?  In that case,
testing whether the packet has been seen before or not (with PINFO_FD_VISITED)
would be a better way.

3) If the header file is only used but this module (as it appears is the case),
it doesn't need to exist; the contents should be rolled into the .c file.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.