Wireshark-bugs: [Wireshark-bugs] [Bug 5695] New: TFTP packet summary shouldn't show the NUL term
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 15 Feb 2011 13:34:36 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5695

           Summary: TFTP packet summary shouldn't show the NUL terminator
                    in strings
           Product: Wireshark
           Version: 1.4.3
          Platform: Other
        OS/Version: Windows Vista
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: DXDragon@xxxxxxxxx


Build Information:
Version 1.4.3 (SVN Rev 35482 from /trunk-1.4)

Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.16.6, with GLib 2.22.4, with WinPcap (version
unknown), with libz 1.2.3, without POSIX capabilities, without libpcre, without
SMI, with c-ares 1.7.1, with Lua 5.1, without Python, with GnuTLS 2.8.5, with
Gcrypt 1.4.5, without Kerberos, with GeoIP, with PortAudio V19-devel (built Jan
11 2011), with AirPcap.

Running on 64-bit Windows Vista Service Pack 2, build 6002, with WinPcap
version
4.1.2 (packet.dll version 4.1.0.2001), based on libpcap version 1.0 branch
1_0_rel0b (20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.

--
The Info column for TFTP request packets looks like this:

Read Request, File: blah.txt\000, Transfer type: octet\000,
blksize\000=1024\000, tsize\000=0\000

It should look like this:

Read Request, File: blah.txt, Transfer type: octet, blksize=1024, tsize=0

Justification: it is more legible and not ambiguous because all those strings
are always NUL-terminated and can't contain other NULs.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.