Wireshark-bugs: [Wireshark-bugs] [Bug 5676] Submitting patch to add 6rd DHCP option support per
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 10 Feb 2011 12:40:46 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5676

Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexis.lagoutte@xxxxxxxxx

--- Comment #4 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-02-10 12:40:45 PST ---
Hi,

+        case 212: {       /* 6RD option (RFC 5969) */
+             struct e_in6_addr prefix;

[..]
+                   /* 6RD Prefix */
+           memset(&prefix, 0, sizeof(prefix));
+           tvb_get_ipv6(tvb, optoff + 2, &prefix);
+           proto_tree_add_text(v_tree, tvb, optoff + 2, 16, 
+                       "6RD Prefix: %s", ip6_to_str(&prefix));


Why not use proto_tree_add_item (in place of protot_tree_add_text) ?
No need to initialize variable and the option is filterable !

(I known, it is not in the style of bootp dissector...)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.