Wireshark-bugs: [Wireshark-bugs] [Bug 5675] New: Rev 35862 - Changes made to airpcap dialog prev
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 10 Feb 2011 02:22:42 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5675

           Summary: Rev 35862 - Changes made to airpcap dialog prevent
                    proper building
           Product: Wireshark
           Version: 1.5.x (Experimental)
          Platform: x86-64
        OS/Version: Ubuntu
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: rknall@xxxxxxxxx


Created an attachment (id=5924)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5924)
Patch to remove airpcap_add_keys_from_list, and change the handling of to
variables

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
With Rev 35862 - various changes lead to a build fail, if -werror is enabled,
all the errors are in airpcap_gui_utils.c

In function airpcap_add_key_to_list, the parameter ssid will never be used if
HAVE_AIRPDCAP is defined. Self-assigning the pointer is not nice-looking, but
resolves the error.

In function airpcap_fill_key_list, the variable s is declared but never used,
removing it does not change behaviour, but removing s2 and changing the
occurences of s2 to s makes more sense.

Function airpcap_add_keys_from_list is not used anymore, therefore could be
removed.

The attached patch applies the changes mentioned above.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.