Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5674] New: Rev 35862 breaks compilation on GCC Ver 4.3 and higher

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5674

           Summary: Rev 35862 breaks compilation on GCC Ver 4.3 and higher
           Product: Wireshark
           Version: SVN
          Platform: x86-64
        OS/Version: Ubuntu
            Status: NEW
          Severity: Blocker
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: rknall@xxxxxxxxx


Created an attachment (id=5923)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5923)
Patch to allow a compiler dependant setting for static/non-static declarations.

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
With Rev 35862, 23 functions in the file airpcap_dlg.c become static, although
their prototypes in airpcap_dlg.h remained non-static. On GCC 4.3, 4.4 and 4.5
this breaks compilation, as GCC prevents this behaviour.

A previous version of GCC (3.4.3) allows compilation, although warns about
this.

Intel C-Compiler, as well as the Microsoft Compilers starting with version
MSVC2005 up until MSVC2010, don't care about this.

PC-Lint does again fail, because of this.

There are three possible solutions to this issue.

1. Find a flag for GCC (not found by me) 
2. Remove the static declarations (easiest, but they might be used on some
systems)
3. Add a CMAKE script, which checks the compiler if it allows such behaviour,
and if it does, allows the 'static' keyword to be added. This has been
implemented by me, the patch is attached to this post.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.