https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5655
--- Comment #13 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2011-02-07 13:09:11 CET ---
(In reply to comment #12)
> Created an attachment (id=5910)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5910) [details]
> corrected, fuzz-tested version
>
> all tabs removed and some minor issues fixed
One thing on header field registrations. Your abbreviation fields doesn't
follow the template:
PROTOABBREV == "docsis_cmstatus"
/* Setup list of header fields See Section 1.6.1 for details*/
static hf_register_info hf[] = {
{ &hf_PROTOABBREV_FIELDABBREV,
{ "FIELDNAME", "PROTOABBREV.FIELDABBREV",
FIELDTYPE, FIELDDISPLAY, FIELDCONVERT, BITMASK,
"FIELDDESCR", HFILL }
}
};
/* Register the protocol name and description */
proto_PROTOABBREV = proto_register_protocol("PROTONAME",
"PROTOSHORTNAME", "PROTOABBREV");
They have to start with "docsis_cmstatus." in order to avoid namespace
pollution.
While you're at it you might get rid of the signedness of 'start' and 'pos' in
dissect_cmstatus_tlv(). Unsigned is better.
Also, your dissector misses the $Id$ in the header.
Keep working the code, you're getting there... ;)
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
