Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5614] New: ./epan/dissectors/packet-ntlmssp.c : space embedded in C comment de

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5614

           Summary: ./epan/dissectors/packet-ntlmssp.c : space embedded in
                    C comment delimiters
           Product: Wireshark
           Version: 1.4.3
          Platform: SPARC
        OS/Version: Solaris
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: irwin@xxxxxxxxxxxxx


Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Platform: Solaris 9 SPARC, gcc 3.3.6


Build fails when  gcc 3.3.6 encounters C comments with
a space embedded in the comment delimiters.

....
if /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.
-I../.. -I./../.. -I./..    -I/usr/local/include -I/usr/local/include
'-DPLUGIN_DIR="/usr/local/lib/wireshark/plugins/1.4.3"' 
-D_U_="__attribute__((unused))" -g -O3 -Wall -W -Wendif-labels -Wpointer-arith
-Wcast-align -Wformat-security -Wno-return-type -DFUNCPROTO=15
-I/usr/local/include -D_REENTRANT -D_PTHREADS -I/usr/local/include/gtk-2.0
-I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0
-I/usr/local/include/cairo -I/usr/local/include/pango-1.0
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
-I/usr/local/include/freetype2 -I/usr/local/include
-I/usr/local/include/libpng12   -I/usr/local/include -MT
libdissectors_la-packet-nt-sonmp.lo -MD -MP -MF
".deps/libdissectors_la-packet-nt-sonmp.Tpo" -c -o
libdissectors_la-packet-nt-sonmp.lo `test -f 'packet-nt-sonmp.c' || echo
'./'`packet-nt-sonmp.c; \
then mv -f ".deps/libdissectors_la-packet-nt-sonmp.Tpo"
".deps/libdissectors_la-packet-nt-sonmp.Plo"; else rm -f
".deps/libdissectors_la-packet-nt-sonmp.Tpo"; exit 1; fi
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I./../.. -I./..
-I/usr/local/include -I/usr/local/include
-DPLUGIN_DIR=\"/usr/local/lib/wireshark/plugins/1.4.3\"
"-D_U_=__attribute__((unused))" -g -O3 -Wall -W -Wendif-labels -Wpointer-arith
-Wcast-align -Wformat-security -Wno-return-type -DFUNCPROTO=15
-I/usr/local/include -D_REENTRANT -D_PTHREADS -I/usr/local/include/gtk-2.0
-I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0
-I/usr/local/include/cairo -I/usr/local/include/pango-1.0
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
-I/usr/local/include/freetype2 -I/usr/local/include
-I/usr/local/include/libpng12 -I/usr/local/include -MT
libdissectors_la-packet-nt-sonmp.lo -MD -MP -MF
.deps/libdissectors_la-packet-nt-sonmp.Tpo -c packet-nt-sonmp.c  -fPIC -DPIC -o
.libs/libdissectors_la-packet-nt-sonmp.o
if /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.
-I../.. -I./../.. -I./..    -I/usr/local/include -I/usr/local/include
'-DPLUGIN_DIR="/usr/local/lib/wireshark/plugins/1.4.3"' 
-D_U_="__attribute__((unused))" -g -O3 -Wall -W -Wendif-labels -Wpointer-arith
-Wcast-align -Wformat-security -Wno-return-type -DFUNCPROTO=15
-I/usr/local/include -D_REENTRANT -D_PTHREADS -I/usr/local/include/gtk-2.0
-I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0
-I/usr/local/include/cairo -I/usr/local/include/pango-1.0
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
-I/usr/local/include/freetype2 -I/usr/local/include
-I/usr/local/include/libpng12   -I/usr/local/include -MT
libdissectors_la-packet-nt-tpcp.lo -MD -MP -MF
".deps/libdissectors_la-packet-nt-tpcp.Tpo" -c -o
libdissectors_la-packet-nt-tpcp.lo `test -f 'packet-nt-tpcp.c' || echo
'./'`packet-nt-tpcp.c; \
then mv -f ".deps/libdissectors_la-packet-nt-tpcp.Tpo"
".deps/libdissectors_la-packet-nt-tpcp.Plo"; else rm -f
".deps/libdissectors_la-packet-nt-tpcp.Tpo"; exit 1; fi
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I./../.. -I./..
-I/usr/local/include -I/usr/local/include
-DPLUGIN_DIR=\"/usr/local/lib/wireshark/plugins/1.4.3\"
"-D_U_=__attribute__((unused))" -g -O3 -Wall -W -Wendif-labels -Wpointer-arith
-Wcast-align -Wformat-security -Wno-return-type -DFUNCPROTO=15
-I/usr/local/include -D_REENTRANT -D_PTHREADS -I/usr/local/include/gtk-2.0
-I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0
-I/usr/local/include/cairo -I/usr/local/include/pango-1.0
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
-I/usr/local/include/freetype2 -I/usr/local/include
-I/usr/local/include/libpng12 -I/usr/local/include -MT
libdissectors_la-packet-nt-tpcp.lo -MD -MP -MF
.deps/libdissectors_la-packet-nt-tpcp.Tpo -c packet-nt-tpcp.c  -fPIC -DPIC -o
.libs/libdissectors_la-packet-nt-tpcp.o
if /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.
-I../.. -I./../.. -I./..    -I/usr/local/include -I/usr/local/include
'-DPLUGIN_DIR="/usr/local/lib/wireshark/plugins/1.4.3"' 
-D_U_="__attribute__((unused))" -g -O3 -Wall -W -Wendif-labels -Wpointer-arith
-Wcast-align -Wformat-security -Wno-return-type -DFUNCPROTO=15
-I/usr/local/include -D_REENTRANT -D_PTHREADS -I/usr/local/include/gtk-2.0
-I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0
-I/usr/local/include/cairo -I/usr/local/include/pango-1.0
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
-I/usr/local/include/freetype2 -I/usr/local/include
-I/usr/local/include/libpng12   -I/usr/local/include -MT
libdissectors_la-packet-ntlmssp.lo -MD -MP -MF
".deps/libdissectors_la-packet-ntlmssp.Tpo" -c -o
libdissectors_la-packet-ntlmssp.lo `test -f 'packet-ntlmssp.c' || echo
'./'`packet-ntlmssp.c; \
then mv -f ".deps/libdissectors_la-packet-ntlmssp.Tpo"
".deps/libdissectors_la-packet-ntlmssp.Plo"; else rm -f
".deps/libdissectors_la-packet-ntlmssp.Tpo"; exit 1; fi
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I./../.. -I./..
-I/usr/local/include -I/usr/local/include
-DPLUGIN_DIR=\"/usr/local/lib/wireshark/plugins/1.4.3\"
"-D_U_=__attribute__((unused))" -g -O3 -Wall -W -Wendif-labels -Wpointer-arith
-Wcast-align -Wformat-security -Wno-return-type -DFUNCPROTO=15
-I/usr/local/include -D_REENTRANT -D_PTHREADS -I/usr/local/include/gtk-2.0
-I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0
-I/usr/local/include/cairo -I/usr/local/include/pango-1.0
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
-I/usr/local/include/freetype2 -I/usr/local/include
-I/usr/local/include/libpng12 -I/usr/local/include -MT
libdissectors_la-packet-ntlmssp.lo -MD -MP -MF
.deps/libdissectors_la-packet-ntlmssp.Tpo -c packet-ntlmssp.c  -fPIC -DPIC -o
.libs/libdissectors_la-packet-ntlmssp.o
packet-ntlmssp.c:2499:15: missing terminating ' character
packet-ntlmssp.c:2537:43: missing terminating ' character
packet-ntlmssp.c:2548:56: missing terminating ' character
gmake[5]: *** [libdissectors_la-packet-ntlmssp.lo] Error 1
gmake[5]: Leaving directory
`/var/local/src/wireshark-1.4.3+PU-1/epan/dissectors'
gmake[4]: *** [all-recursive] Error 1
gmake[4]: Leaving directory
`/var/local/src/wireshark-1.4.3+PU-1/epan/dissectors'
gmake[3]: *** [all] Error 2
gmake[3]: Leaving directory
`/var/local/src/wireshark-1.4.3+PU-1/epan/dissectors'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/var/local/src/wireshark-1.4.3+PU-1/epan'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/var/local/src/wireshark-1.4.3+PU-1'
gmake: *** [all] Error 2





Relevant lines from  ./epan/dissectors/packet-ntlmssp.c are

2499     / * We don't have any packet state, so create one * /

2536     / * Store the decrypted contents in the packet state struct
2537        (of course at this point, they aren't decrypted yet) * /

2547     / * We setup a temporary buffer so we can re-encrypt the payload after
2548        decryption.  This is to update the opposite peer's RC4 state * /




When built with gcc 4.2.4 on Solaris 9 SPARC, those errors are instead just
warnings,
so the build continues:

...
if /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.
-I../.. -I./../.. -I./..    -I/usr/local/include -I/usr/local/include
'-DPLUGIN_DIR="/usr/local/lib/wireshark/plugins/1.4.3"' 
-D_U_="__attribute__((unused))" -g -O3 -Wall -W -Wextra
-Wdeclaration-after-statement -Wendif-labels -Wpointer-arith -Wno-pointer-sign
-Wcast-align -Wformat-security -Wno-return-type -DFUNCPROTO=15
-I/usr/local/include -D_REENTRANT -D_PTHREADS -I/usr/local/include/gtk-2.0
-I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0
-I/usr/local/include/cairo -I/usr/local/include/pango-1.0
-I/usr/openwin/include -I/usr/local/include/glib-2.0
-I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1
-I/usr/local/include/freetype2 -I/usr/local/include
-I/usr/local/include/libpng12   -I/usr/local/include -MT
libdissectors_la-packet-ntlmssp.lo -MD -MP -MF
".deps/libdissectors_la-packet-ntlmssp.Tpo" -c -o
libdissectors_la-packet-ntlmssp.lo `test -f 'packet-ntlmssp.c' || echo
'./'`packet-ntlmssp.c; \^M
then mv -f ".deps/libdissectors_la-packet-ntlmssp.Tpo"
".deps/libdissectors_la-packet-ntlmssp.Plo"; else rm -f
".deps/libdissectors_la-packet-ntlmssp.Tpo"; exit 1; fi^
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I./../.. -I./..
-I/usr/local/include -I/usr/local/include
-DPLUGIN_DIR=\"/usr/local/lib/wireshark/plugins/1.4.3\"
"-D_U_=__attribute__((unused))" -g -O3 -Wall -W -Wextra
-Wdeclaration-after-statement -Wendif-labels -Wpointer-arith -Wno-pointer-sign
-Wcast-align -Wformat-security -Wno-return-type -DFUNCPROTO=15
-I/usr/local/include -D_REENTRANT -D_PTHREADS -I/usr/local/include/gtk-2.0
-I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0
-I/usr/local/include/cairo -I/usr/local/include/pango-1.0
-I/usr/openwin/include -I/usr/local/include/glib-2.0
-I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1
-I/usr/local/include/freetype2 -I/usr/local/include
-I/usr/local/include/libpng12 -I/usr/local/include -MT
libdissectors_la-packet-ntlmssp.lo -MD -MP -MF
.deps/libdissectors_la-packet-ntlmssp.Tpo -c packet-ntlmssp.c  -fPIC -DPIC -o
.libs/libdissectors_la-packet-ntlmssp.o
packet-ntlmssp.c:2499:15: warning: missing terminating ' character
packet-ntlmssp.c:2537:43: warning: missing terminating ' character
packet-ntlmssp.c:2548:56: warning: missing terminating ' character


Removing the space embedded in the comment delimiters solves it.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.