Wireshark-bugs: [Wireshark-bugs] [Bug 5583] New: osi-options dissector : dissect_option_route wr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 14 Jan 2011 02:11:13 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5583

           Summary: osi-options dissector : dissect_option_route wrong
                    parsing of NET
           Product: Wireshark
           Version: 1.4.2
          Platform: x86
        OS/Version: Linux (other)
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: keysandwood@xxxxxxxx


Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
dissect_option_route parse the first byte of NET as the NET length, resulting
in incorrect parsing for option OSI_OPT_RECORD_OF_ROUTE.

Fix : netl is one byte before the one actually parsed.
change   this_hop = offset + 3; 
   => this_hop = offset + 2;

and
  /* netl = tvb_get_guint8(tvb, this_hop + 1); */
=>    netl = tvb_get_guint8(tvb, this_hop );


I think the misunderstanding comes from the fact that the third octet begins
the NET list, but the first octet (Parameter Code 0xCB) is not on the buffer
received by  dissect_option_route. 

Maybe same problem for OSI_OPT_SOURCE_ROUTING.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.