Wireshark-bugs: [Wireshark-bugs] [Bug 4048] protocol AMQP: packet-amqp.c:1240: failed assertion
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 4 Jan 2011 00:09:19 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4048

Guy Harris <guy@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Guy Harris <guy@xxxxxxxxxxxx> 2011-01-04 00:09:18 PST ---
One should not use DISSECTOR_ASSERT() to catch problems with packets.  I
suppose what the DISSECTOR_ASSERT() reports is true, in that any time when a
packet can cause you to execute a DISSECTOR_ASSERT() call, it means your
dissector isn't explicitly handling bad packet data, which means your dissector
is buggy - but if a DISSECTOR_ASSERT() is tripped, it means the dissector has a
bug *that should be fixed*.

Rev 35357 has a change that eliminates the DISSECTOR_ASSERT() calls in favor of
explicitly reporting errors and/or triggering bounds-check assertions in the
tvbuff code.  I'll schedule it for 1.4 and 1.2.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.