Wireshark-bugs: [Wireshark-bugs] [Bug 5525] BT L2CAP dissector does not handle several BT conver
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 28 Dec 2010 01:45:52 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5525

--- Comment #2 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2010-12-28 10:45:50 CET ---
Quick review :
No use of C++ style comments allowed.
Please remove the debug code.

specific to packet-btavdtp.c:
Replace xx2str() into using value_string and calls to str_to_val().
Please use descriptive labels in your case statements i.s.o. integers.
Why the extensive use of proto_tree_add_text()? This stops you from using
display filters. The most compact presentation isn't the best, use subtrees for
that, also for bitfields.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.