Wireshark-bugs: [Wireshark-bugs] [Bug 5451] RTP-MIDI - dissector for transmission of MIDI-comman
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 27 Dec 2010 05:30:27 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5451

--- Comment #4 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2010-12-27 14:30:23 CET ---
(From update of attachment 5540)
quick review:
Use of "" should be replaced by meaningful 'unknown value' message.

These codes snippets
        /* Can we read the program change chapter? */
        if ( ( offset + 3 ) > tvb->length ) {
            return -1;
        }

should make use of calls to tvb_bytes_exist()

I recommend against using 97 as default payload type, since every one and it's
mother *assume* that this dynamic value would be available...

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.