Wireshark-bugs: [Wireshark-bugs] [Bug 5491] Outlook anywhere: ncacn_http support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 23 Dec 2010 08:06:09 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5491

--- Comment #7 from Julien Kerihuel <j.kerihuel@xxxxxxxxxxxxxx> 2010-12-23 08:06:08 PST ---
(In reply to comment #5)
> The DISSECTOR_ASSERT(info_str); has to go. A dissector always has to be able to
> accept incorrect packet data. This assert is only to guard against 'real'
> dissector errors.
> Also descriptive labels in the switch statements would be appreciated.

Hi Jaap,

I've updated the patch (with Dirk modifications) and added/change:

1. Removed the DISSECTOR_ASSERT(info_str);
2. added RTS command defines to improve code readability

Regarding the rts_flags switch, I'm unsure whether additional comments would
really be worthwhile. The packet names provided in MS-RPCH are mainly for
information purposes only  and only depends on the number of commands, commands
and ordering. Furthermore, in the future, I plan to improve it and make this
"connection aware".

Understand: if it belongs to the outbound proxy, then it even restrict choices
more than what is currently displayed. For the moment the switch/case is
exhaustive.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.