Wireshark-bugs: [Wireshark-bugs] [Bug 5450] Reassembly function works with V1.2.1, but doesn't w
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 16 Dec 2010 17:03:23 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5450

Jonathan Atkins <JonathanCAtkins@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #3 from Jonathan Atkins <JonathanCAtkins@xxxxxxxxx> 2010-12-16 17:03:22 PST ---
(In reply to comment #2)
> Reassembly only happens on the first pass through the file.  I'm not aware of
> this changing between 1.2 and 1.4, but I haven't paid attention to the
> reassembly stuff.
> 
> This means that your dissector(s) need to be sure to call the reassembly
> functions even when (!tree).
> 
> Could that be the problem?  Jonathan's comments about the different behavior
> with and without a display filter (which controls whether or not tree is set)
> makes me suspect it.

that was it!  my reassembly now happens without the filter.
Thanks!  I dunno what changed between versions but it revealed this coding
style error.  Suggest to update docs to remind developer to always do the
fragment processing whether or not tree is non-null.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.