Wireshark-bugs: [Wireshark-bugs] [Bug 5466] Improve dissection of bit-oriented fields, text fiel
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 6 Dec 2010 11:55:59 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5466

--- Comment #10 from Richard Sharpe <realrichardsharpe@xxxxxxxxx> 2010-12-06 11:55:59 PST ---
(In reply to comment #9)
> Hmm,
> 
> I get these:
> 
> [rsharpe@localhost wireshark]$ ./tools/checkhf.pl epan/dissectors/packet-scsi.c 
> ERROR: NO ARRAY: epan/dissectors/packet-scsi.c, hf_scsi_persresv_control_unreg
> Unused entry: epan/dissectors/packet-scsi.c, hf_scsi_control
> Unused entry: epan/dissectors/packet-scsi.c, hf_scsi_alloclen16
> 
> The first is due to some additional stuff in my source that I have not yet set
> up correctly.
> 
> The other two are interesting. Checking now.

OK, I think they are false positives in that checkhf does not understand calls
to 

        proto_tree_add_bitmask(tree, tvb, offset+8, hf_scsi_control,
                ett_scsi_control, cdb_control_fields, FALSE);

hf_scsi_control is passed to that call, so it is used. So to is
hf_scsi_alloclen16

        proto_tree_add_item (tree, hf_scsi_alloclen16, tvb, offset+6, 2, 0);

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.