Wireshark-bugs: [Wireshark-bugs] [Bug 1190] over 2GBytes files have incorrect size in the open d
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1190
--- Comment #13 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-11-23 22:10:26 PST ---
(In reply to comment #12)
> (In reply to comment #6)
>
> > Or, if we're daring enough, we could come up with a patch for zlib and compile
> > it while compiling Wireshark :-)
>
> Another option would be to include the necessary parts of zlib's source code in
> our source code (it has a BSD style license) and then modify the variables to
> be 64-bit even on 32-bit platforms.
Both of these are good ideas as well. Overall, I think your "daring" idea is
the best way to solve this since it fixes the problem at its source. But Jeff
mentioned in comment 8 that, "It sounded to me like they've no intention of
adding 64-bit offset support in 32-bit libraries, though I don't know if anyone
has asked (or submitted a patch for 64-bit-offset APIs :-)).", so maybe the
first step is to see if the zlib team is working on this already and if not, if
they would be willing to accept patches that do implement it. If they don't
want any part of that, then we're left with one of your other two choices.
However, taking the necessary parts of zlib's source means essentially we're
branching zlib and won't benefit from other bug fixes or enhancements that
might come along later on in zlib's source, so something to keep in mind. I
guess another alternative is to switch to some other open source compression
library that already supports 64-bit offsets. I haven't researched any though.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
