Wireshark-bugs: [Wireshark-bugs] [Bug 5376] new dissector for the SAMETIME protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 16 Nov 2010 18:09:13 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5376

Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeff.morriss.ws@xxxxxxxxx

--- Comment #7 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2010-11-16 18:09:11 PST ---
Looks good.  One problem prevents me from checking it in, though: there's no
copyright notice.  Rather than assume (which I suppose might be tricky
legally-speaking), could you add the standard one (e.g., from
doc/README.developer)?

Also, proto_register_sametime() should be at the end of the file (as in all the
other dissectors).  That can easily be moved when checking it in, though.

One more: there's a global variable for the TCP port but there's no preference.
 http://www-10.lotus.com/ldd/stwiki.nsf/dx/ports-used-by-the-sametime-server
indicates that different ports /can/ be used, so should there be a preference?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.