Wireshark-bugs: [Wireshark-bugs] [Bug 5400] [PATCH] Add many more DAAP codes to packet-daap.c, f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 16 Nov 2010 06:45:19 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5400

--- Comment #6 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2010-11-16 06:45:17 PST ---
(In reply to comment #5)
> > The patch looks good, but we should have something somewhere to test the
> > dissector against--I'm guessing you have one?
> 
> Didn't know it was a blocker for patch inclusion. Is that new?

Well, it depends on a few things, but in this case I thought that due to the
size of the patch I should at least do some basic sanity checking.

And having sample captures is always a good thing: those attached to the bug
database automatically go into the pool of captures that get fuzz tested, for
example.  And if any of us ever need to work on the dissector, we'll have
something to regression test against.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.