Wireshark-bugs: [Wireshark-bugs] [Bug 5403] Buildbot crash output: fuzz-2010-11-14-3053.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 15 Nov 2010 12:44:21 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5403

--- Comment #13 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-11-15 15:44:20 EST ---
(In reply to comment #12)
> (In reply to comment #11)
> > Side note: should this dissector be using tvb_reported_length_remaining()
> > (e.g., in case the packets were cut short while being captured)?
> 
> Noob question: would the tvb_reported_length_remaining() be less than
> tvb_length_remaining() if packets were truncated, for example, by setting the
> "Capture / Option... / Limit each packet to [...] bytes"?

Actually: the other way around:

tvb_length...    is based upon the actual capture length
tvb_reported_length  is based upon the length if the packet weren't truncated.

In general tvb_reported length should be used. If a a fetch from a tvb goes
"off the end" Wireshark will show an exception message depending whether the
access is beyond the reported-length or not; 

See epan/exceptions.h for info on ReportedBoundsError vs BoundsError

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.