Wireshark-bugs: [Wireshark-bugs] [Bug 5369] New: Use Always MIN() and MAX()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 3 Nov 2010 09:51:45 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5369

           Summary: Use Always MIN() and MAX()
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: alexis.lagoutte@xxxxxxxxx


Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Hi

Replace all *_min()/*_max() by MIN() and MAX()

Also for packet-iscsi.c and packet-q931.c, fix checkhf warning

Unused entry: dissectors/packet-iscsi.c, hf_iscsi_SCSICommand_AddCDB => unused
from  Rev 4043
Unused entry: dissectors/packet-iscsi.c, hf_iscsi_write_data => unused from
rev4508
Unused entry: dissectors/packet-iscsi.c, hf_iscsi_read_data => unused from
rev4508
Unused entry: dissectors/packet-iscsi.c, hf_iscsi_InitCmdSN => unused from
rev4043
Unused entry: dissectors/packet-iscsi.c, hf_iscsi_InitStatSN => unused from
rev4043
Unused entry: dissectors/packet-iscsi.c, hf_iscsi_AHS => unused from rev19376

Unused entry: dissectors/packet-q931.c, hf_q931_message_type => false postive

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.