Wireshark-bugs: [Wireshark-bugs] [Bug 5362] New: Bug in packet-ieee802154.c results in possible
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 3 Nov 2010 02:57:24 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5362

           Summary: Bug in packet-ieee802154.c results in possible null
                    pointer access attempt
           Product: Wireshark
           Version: SVN
          Platform: Other
        OS/Version: Windows XP
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: coflynn@xxxxxxxxx


Created an attachment (id=5414)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5414)
Patch for packet-ieee802154.c to fix memory access error

Build Information:
Built from latest SVN.

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GTK+ 2.16.6, with GLib 2.24.2, with WinPcap (version
unknown), with libz 1.2.3, without POSIX capabilities, without libpcre, with
SMI
0.4.8, with c-ares 1.7.1, with Lua 5.1, without Python, with GnuTLS 2.8.5, with
Gcrypt 1.4.5, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built
Oct
19 2010), with AirPcap.

Running on Windows XP Service Pack 3, build 2600, with WinPcap version 4.1.2
(packet.dll version 4.1.0.2001), based on libpcap version 1.0 branch 1_0_rel0b
(20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
The packet-ieee802154.c file uses the "ieee_hints" pointer to pass information
to higher layers.

Depending on the higher layer this may be null, and access to it is usually
performed with a check for such. This is missed in one spot which can result in
a memory access error if the pointer is null. 

I cannot attach a test case, as the problem came up with a proprietary plug-in.
However the patch is extremely simple and an 'obvious' bug if you compare how
ieee_hints is accessed in the rest of the file.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.