Wireshark-bugs: [Wireshark-bugs] [Bug 5285] Wireshark crashes with "Gtk-ERROR **: Byte index 6 i
Date: Tue, 26 Oct 2010 11:33:59 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5285

--- Comment #7 from Alexander Koeppe <format_c@xxxxxxxxx> 2010-10-26 11:33:58 PDT ---
(In reply to comment #6)
> Hi,
> I tried the patch and it works of course but I'm not sure it's the right/best
> solution. Wouldn't it be better to keep the value there and indicating that
> that segment is cut short? I'm also wondering if the fix should be in the code
> doing the higlighting insted. I tried adding a -1 as lenght but that's not
> alowed for FT_INT.
> /Anders

Well if you compare the amount of PDUs in the TCP tree and in the PROTO tree,
without the patch you'd have 7 PDUs + 118 Bytes remaining data (which is
obviously wrong) and with the patch you'll have 6 PDUs + 118 Bytes of data
which is exactly what is in the packet and in the prototree.

That's why I've chosen to keep the uncomplete PDU away from the TCP tree as it
is (by default) in the PROTO tree.

Cheers

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.