Wireshark-bugs: [Wireshark-bugs] [Bug 5048] VeriWave encapsulation type and WaveAgent protocol -
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5048
--- Comment #12 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-10-25 15:34:58 EDT ---
OK: A few more comments:
1. As Jaap requested: Please be consistent: leading tabs or spaces;
as well as consistent indentation.
(There seems to be some 2 space indentation mixed in).
Also: the source files appear to be using "4 space tabs". This
doesn't really play well with editors/programs which tend to have
tabs defined to be every 8 columns.
I suggest converting all the tabs to (4) spaces.
2. vwr.c: All the functions and the global variables (other than vwr_open)
should be defined as static.
3. packet-vw-radiotap.h and packet-ethernettap.h are not needed;
(The externs for the proto_register & proto_reg_handoff fcns
are generated as needed as part of the automatic generation
of the fcns which call these fcns).
4. packet-vw-radiotap.c: We prefer that the proto_register and
proto_reg_handoff functions be at the end of the file.
5. A new wiretap reader has recently been added to Wireshark and thus
the patches no longer apply cleanly.
So: you'll need to update your Wireshark sources and then adjust
wtap.h, wtap.c and file_access.c accordingly before recreating
the patch.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
