Wireshark-bugs: [Wireshark-bugs] [Bug 5321] New: Cleanup of unnecessary tree == NULL checks in Z
Date: Wed, 20 Oct 2010 13:04:04 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5321

           Summary: Cleanup of unnecessary tree == NULL checks in ZCL
                    dissector
           Product: Wireshark
           Version: 1.5.x (Experimental)
          Platform: Other
        OS/Version: Windows XP
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: fff@xxxxxxxxxx


Created an attachment (id=5346)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5346)
ZCL Cleanup Patch

Build Information:
Version 1.5.0-etl-5.4 (SVN Rev 34591 from /trunk)

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.16.6, (32-bit) with GLib 2.24.2, with WinPcap (version
unknown), with libz 1.2.3, without POSIX capabilities, without libpcre, with
SMI
0.4.8, with c-ares 1.7.1, with Lua 5.1, without Python, with GnuTLS 2.8.5, with
Gcrypt 1.4.5, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built
Oct
19 2010), with AirPcap.

Running on Windows XP Service Pack 3, build 2600, with WinPcap version 4.1.2
(packet.dll version 4.1.0.2001), based on libpcap version 1.0 branch 1_0_rel0b
(20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729
--
This patch cleans up the many unnecessary checks for a null tree in the ZCL
dissector noticed by Anders Broman. The same zcl-cmds-v2.pcap test file
attached to bug 5303
(https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5320) can be used to
test this patch.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.