Wireshark-bugs: [Wireshark-bugs] [Bug 5316] Add dissector for VXI-11 Protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 19 Oct 2010 09:34:32 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5316

--- Comment #4 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-10-19 12:34:31 EDT ---
A few preliminary minor notes:

1. // shouldn't be used;
   use #if 0/#endif to comment out code

2. Unless packet-vxi.h is (or will be) used elsewhere please just include
   the defines & etc in packet-vxi.c.

3. packet-vxi.c should be added to epan/CMakelists.txt as well as 
   .../.../Makefile.common.

   Please add packet-vxi.c in right alphabetical place.

b

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.