Wireshark-bugs: [Wireshark-bugs] [Bug 3894] File-Open Display Filter is overwritten by Save-As F
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 15 Oct 2010 08:56:23 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3894

--- Comment #13 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-10-15 08:56:18 PDT ---
(In reply to comment #12)
> My reading of Guy's comment was to use the g_ versions so that we can keep the
> pointer to the string around as long as we want so we can maintain the ability
> to preserve the filter string from Open to Open (or Merge to Merge).  Otherwise
> there's no need to switch to the malloc'd memory.

Guy, is that what you had in mind?

On other platforms (I tested it on Linux), the previous filter used is not
preserved, so I didn't think it was really needed, thus I opted to remove it.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.