Wireshark-bugs: [Wireshark-bugs] [Bug 3507] New protocol dissectors for V.150.1 (modem over IP):
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 6 Oct 2010 08:01:08 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3507

--- Comment #10 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2010-10-06 08:01:05 PDT ---
Hi,
Well Bill asked a question at 2010-01-03 still unanswered...
Quickly looking at the code a few comments.

- The fetch from tvb and subsequent ..add_unit.. ..add_boolean... could be
replaced by the prefered proto_add_item()
- check_col() is deprecaded as it's no longer needed.
- Empty hf blurbs
+                "", HFILL
should be replaced by NULL
+                NULL, HFILL
Regards
Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.