Wireshark-bugs: [Wireshark-bugs] [Bug 5270] diff for a new dissector for COAP (draft-ietf-core-c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 4 Oct 2010 02:25:19 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270

Stig Bjørlykke <stig@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5254|                            |review_for_checkin-
               Flag|                            |

--- Comment #2 from Stig Bjørlykke <stig@xxxxxxxxxxxxx> 2010-10-04 02:25:12 PDT ---
(From update of attachment 5254)
Some review comments:
- Terminate all value_string's with { 0, NULL }
- Use the macro MIN instead of coap_min()
- Use proto_tree_add_item() instead of proto_tree_add_string with a
tvb_get_ptr()
- You should set COL_PROTOCOL and COL_INFO even when not having parent_tree in
dissect_coap()
- Remove debug code
- Don't call exit() within your code

Can you provide a sample capture file?
Did you run tools/fuzz-test.sh on a coap capture file?
Remember to set review_for_checkin on your patch.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.