Wireshark-bugs: [Wireshark-bugs] [Bug 5248] New dissector for WAI authentication protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 22 Sep 2010 10:30:37 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5248

Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeff.morriss.ws@xxxxxxxxx

--- Comment #7 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2010-09-22 10:30:33 PDT ---
(In reply to comment #6)
> I've committed one bug fix (and a few minor changes) in SVN #34183.
> 
> A question for one of the core developers:
> 
> readme.DEVELOPER says 
> 
>    Note, however, that you must fill in column information, create
>    conversations, reassemble packets, build any other persistent state
>    needed for dissection, and call subdissectors regardless of whether
>    "tree" is NULL or not.  This might be inconvenient to do without
> 
> In packet-wai.c some of the reassembly functions are called under 'if (tree)'.
> 
> Do these calls need to be done outside of the 'if(tree)' ??

Yes.  I ran into that problem in another dissector (and fixed it in rev 32812).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.