Wireshark-bugs: [Wireshark-bugs] [Bug 5067] Patch to add FastCGI dissector
Date: Mon, 16 Aug 2010 18:12:20 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5067

Bill Meier <wmeier@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5051|review_for_checkin?         |review_for_checkin+
               Flag|                            |

--- Comment #4 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-08-16 21:12:16 EDT ---
(From update of attachment 5051)
Committed: SVN #33824 & #33825

Thanks !!

I changed 

         namelen = tvb_get_ntohl(tvb, offset)
         ...
         valuelen = tvb_get_ntohl(tvb, offset)

to:
         namelen = tvb_get_ntohl(tvb, offset) & 0x7FFFFFF;
         ...
         valuelen = tvb_get_ntohl(tvb, offset) & 0x7FFFFFF;

since the spec shows that the leading bit is not part of namelen and valuelen
when they are 4 byte values.

Please verify ....

I also added a comment as to a seeming bug in Wireshark tcp_dissect_pdus()
which seems to prevent appending anything to COL_INFO for the 2nd, 3rd, ...
FCGI PDU within a TCP frame.
(I willl file a separate bug for this).


Re:

> I haven't been able to reproduce the problem described in point 2 so perhaps
> you could explain in more detail what the problem is that you're seeing?

I must have been mistaken. The packet bytes highlighting for frame #98 is AOK.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.