Wireshark-bugs: [Wireshark-bugs] [Bug 4997] Wireshark SSTP dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 17 Jul 2010 01:49:19 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4997

--- Comment #6 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2010-07-17 10:49:04 CEST ---
How well does play with HTTPS, which is also in port 443 ?

I still don't get what this does:

  /* Check that it is not SSTP/HTTP request */
  head = tvb_get_string(tvb, 0, 4);

  if ((strncmp((char*)head,"HTTP", 4) == 0) || (strncmp((char*)head,"SSTP", 4)
== 0))
    return ;

  g_free(head);

What if there are other methods being used on SSL/443? Wouldn't this require a
conversation setup based on seeing SSTP_DUPLEX_POST?
And, it still leaks memory.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.